Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme: fix darwin build #83528

Merged
merged 1 commit into from Mar 28, 2020
Merged

acme: fix darwin build #83528

merged 1 commit into from Mar 28, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 27, 2020 •
edited

Motivation for this change

noticed it was broken on hydra

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from OPNA2608 March 27, 2020 20:49
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build acme

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build acme

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 27, 2020
@jonringer
Copy link
Contributor Author 

[2 built, 1 copied (1.4 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83528
2 package built:
acme cheesecutter

@jonringer jonringer merged commit da41b78 into NixOS:master Mar 28, 2020
@jonringer jonringer deleted the fix-acme-darwin branch July 8, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @OPNA2608