Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs/brlaser: upgrade to v6 #79246

Merged
merged 1 commit into from Apr 18, 2020
Merged

nixpkgs/brlaser: upgrade to v6 #79246

merged 1 commit into from Apr 18, 2020

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Feb 5, 2020

Why

It introduces support for several additional Brother printers:

Brother HL-2030 series
Brother HL-2140 series
Brother HL-2220 series
Brother HL-2270DW series
Brother HL-5030 series
Brother DCP-L2520D series

https://github.com/pdewacht/brlaser/releases/tag/v6

Testing

I've tested this on Linux with HL-2140 and it works without any issues.

Notify maintainers

@StijnDW

It introduces support for several additional Brother printers.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Copy link
Contributor

@Stekke Stekke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr :)

@jakubgs
Copy link
Contributor Author

jakubgs commented Feb 10, 2020

What's missing to merge this?

@jakubgs
Copy link
Contributor Author

jakubgs commented Feb 12, 2020

Do we need another reviewer?

@Stekke
Copy link
Contributor

Stekke commented Feb 12, 2020

Nothing is missing as far as I know.
Someone from the Nixpkgs committers team will merge this when they have time.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/19

@bhipple
Copy link
Contributor

bhipple commented Apr 18, 2020

Result of nixpkgs-review pr 79246 1

1 package built:
- brlaser

@bhipple bhipple merged commit 78760d1 into NixOS:master Apr 18, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 18, 2020

LGTM, despite the "major version" upgrade the changelog appears to imply just adding new features, and it has no reverse dependencies, so 👍

EDIT: Didn't notice this initially, but for future reference the commit subject and PR title should be:

brlaser: 5 -> 6

Per guidelines on https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants