Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lorri: unstable-2020-01-09 -> 1.0 (backport to release-19.09) #79261

Merged
merged 1 commit into from Feb 5, 2020
Merged

lorri: unstable-2020-01-09 -> 1.0 (backport to release-19.09) #79261

merged 1 commit into from Feb 5, 2020

Conversation

curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Feb 5, 2020 •
edited

Cherry-picked from commit 42a2668.

Motivation for this change

Backport of #79230. We want lorri 1.0, the first stable version, in NixOS 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@curiousleo
lorri: unstable-2020-01-09 -> 1.0
f375592 
(cherry picked from commit 42a2668)
@ofborg ofborg bot added the 6.topic: nixos label Feb 5, 2020
@ofborg ofborg bot requested review from Profpatsch and grahamc February 5, 2020 12:14
@curiousleo curiousleo marked this pull request as ready for review February 5, 2020 12:40
@curiousleo curiousleo mentioned this pull request Feb 5, 2020
Closed
@curiousleo
Copy link
Contributor Author

@GrahamcOfBorg build lorri.tests

@grahamc grahamc merged commit 34b08ff into NixOS:release-19.09 Feb 5, 2020
@curiousleo curiousleo deleted the lorri-1.0-backport branch February 5, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curiousleo @grahamc