Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lorri: unstable-2020-01-09 -> 1.0 #79230

Merged
merged 1 commit into from Feb 5, 2020
Merged

lorri: unstable-2020-01-09 -> 1.0 #79230

merged 1 commit into from Feb 5, 2020

Conversation

curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Feb 4, 2020 •
edited

Motivation for this change

lorri has reached version 1.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (trivial: there aren't any)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@curiousleo curiousleo mentioned this pull request Feb 4, 2020
Closed
@ofborg ofborg bot requested review from Profpatsch and grahamc February 4, 2020 16:36
@curiousleo curiousleo marked this pull request as ready for review February 4, 2020 16:46
curiousleo
curiousleo commented Feb 4, 2020
View reviewed changes
pkgs/tools/misc/lorri/default.nix
@@ -27,11 +27,11 @@ rustPlatform.buildRustPackage rec {
owner = "target";
repo = pname;
# Run `eval $(nix-build -A lorri.updater)` after updating the revision!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build lorri.tests

@grahamc
Copy link
Member

grahamc commented Feb 4, 2020

lgtm, but no idea why the tests failed. Let's try again:

@GrahamcOfBorg build lorri.tests

@Profpatsch
Copy link
Member

Test fails.

@ofborg ofborg bot added the 6.topic: nixos label Feb 5, 2020
@curiousleo curiousleo mentioned this pull request Feb 5, 2020
Merged
3 tasks
@curiousleo
Copy link
Contributor Author

@GrahamcOfBorg build lorri.tests

@curiousleo
Copy link
Contributor Author

Test passes. Sorry I forgot to update it before! I've amended the publishing procedure accordingly: target/lorri#326

Profpatsch
Profpatsch approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see 1.0!! Thanks @curiousleo @grahamc for your tireless work.

@Profpatsch Profpatsch merged commit 42a2668 into NixOS:master Feb 5, 2020
@curiousleo curiousleo deleted the lorri-1.0 branch February 5, 2020 11:49
@curiousleo curiousleo mentioned this pull request Feb 5, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curiousleo @Profpatsch @grahamc