New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible/invalid orders aren't marked as such in the order list #7972
Comments
I think the actual issue here is that the invalid orders (bus to truck stop) are not properly marked as such in the order list. (e.g. like when the station is removed entirely) It's perfectly reasonable to not copy invalid orders (when not sharing), and it mostly makes sense that the invalid order is copied when sharing. You can't unshare the list as that would create an invalid order, which isn't allowed. You can delete the invalid order (which should be displayed as such), and then you can successfully unshare. |
Edited title and description to expose the actual issue more (it still occurs in 1.10.2). |
This happens for more than only buses vs trucks. It basically happens for everything :) Pointing a train to a train-station, connect a bus-station, remove the train-station, same issue :) |
A solution is a bit more tricky than I was expecting. Initially, I was thinking doing the same as when removing stations: just make the order invalid. But what if you remove the Bus station to place it on a new spot seconds later. All orders would already been invalidated (and they will not recover). So that is far from ideal. Using a timeout, as with stations, is also difficult, as there is no visual feedback on that. Guess we could mark it red or something (and postfix it with |
As long as there's some way to see that the order is invalid without overwriting the order itself with Maybe also display a warning when copying impossible orders in order to allow players to better resolve such orders? For example: "Vehicle contains invalid orders" (though there's also "Vehicle can't go to all stations"). |
Copying no longer silently fails with #8515, so that would open the way to just mark the order as invalid (instead of removing it). Still not sure it is the best thing to do :) |
I'm having a few thoughts about order lists, that may or may not be related to the problem here:
|
Is what I came up with for now. It complements 1), as they both now show the same information. It works for any station the vehicle is not compatible with, so all of your 2), and I think the text is clear enough to solve 3) too. Well, partially .. it is still bloated .. you can now get this: or this: :D |
that your second screenshot is much wider than the first is proof that 3) is an actual problem :) |
…our vehicle Before it was shown as a normal order, but the vehicle was skipping it. This was rather unclear to the user. Now it is red and contains text with some hints what is going on. The text is prefixed rather than postfixed, as we have many postfixes already.
…our vehicle Before it was shown as a normal order, but the vehicle was skipping it. This was rather unclear to the user. Now it is red and contains text with some hints what is going on. The text is prefixed rather than post-fixed, as we have many post-fixes already.
…our vehicle Before it was shown as a normal order, but the vehicle was skipping it. This was rather unclear to the user. Now it is red and contains text with some hints what is going on. The text is prefixed rather than post-fixed, as we have many post-fixes already.
…our vehicle Before it was shown as a normal order, but the vehicle was skipping it. This was rather unclear to the user. Now it is red and contains text with some hints what is going on. The text is prefixed rather than post-fixed, as we have many post-fixes already.
…icle (#8516) Before it was shown as a normal order, but the vehicle was skipping it. This was rather unclear to the user. Now it is red and contains text with some hints what is going on. The text is prefixed rather than post-fixed, as we have many post-fixes already.
Version of OpenTTD
d7a928a
(Based on #5213, meaning that it was also broken in 1.2.1)
Expected result
If you clone a vehicle whose orders are impossible to make (e.g. a bus going to a truck-only station), the orders will be copied into the new vehicle. Attempting to share/unshare order lists with impossible orders works normally.
Actual result
If you clone a vehicle whose orders are impossible to make (e.g. a bus going to a truck-only station), the orders will not be copied into the new vehicle and no error message is displayed. Attempting to share/unshare order lists with impossible orders fails.
Steps to reproduce
The text was updated successfully, but these errors were encountered: