pijul: Fix the build (broke due to a more recent Rust version) #79223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses an upstream patch [0] to fix a compatibility error with a new version of Rust. Fix NixOS#79150. Unfortunately patching Rust dependencies in Nixpkgs turned out to be way more hacky than I expected (maybe there is a nicer way?), but it should be fine for now. A new release might follow soonish [1] so that we can drop the patches. References: - https://nest.pijul.com/pijul_org/pijul/discussions/401 - https://nest.pijul.com/pijul_org/thrussh/discussions/31 [0]: https://nest.pijul.com/pijul_org/thrussh:master/patches/AsyuWkJg4jAwNaG3H1yv1kbECx5E3GQAtjzXWBDB8yEGMswyfKbxKvYmAGWCohTVaTipdvF8mHh63yU5PTr5F9py [1]: https://discourse.pijul.org/t/is-this-project-still-active-yes-it-is/451
FlorentBecker
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an upstream patch 0 to fix a compatibility error with a new
version of Rust. Fix #79150.
Unfortunately patching Rust dependencies in Nixpkgs turned out to be way
more hacky than I expected (maybe there is a nicer way?), but it should
be fine for now.
A new release might follow soonish 1 so that we can drop the patches.
References:
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)