Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.3.3 -> 1.3.4 #79201

Merged
merged 1 commit into from Feb 4, 2020
Merged

syncthing: 1.3.3 -> 1.3.4 #79201

merged 1 commit into from Feb 4, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
Copy link
Member

wamserma commented Feb 4, 2020

@GrahamcOfBorg test syncthing-init syncthing-relay

wamserma
wamserma approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Moredread
Moredread approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@Moredread Moredread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked via nixpkgs-review and on my 19.09 machine with my productive syncthing config.

@marsam marsam merged commit 7596dfe into NixOS:master Feb 4, 2020
@marsam marsam deleted the update-syncthing branch February 4, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@Moredread Moredread Moredread approved these changes

@andrew-d andrew-d andrew-d approved these changes

@jokogr jokogr Awaiting requested review from jokogr

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @wamserma @Moredread @andrew-d