Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nawk: 20121220 -> 20180827 #79179

Merged
merged 1 commit into from May 7, 2020
Merged

nawk: 20121220 -> 20180827 #79179

merged 1 commit into from May 7, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Feb 3, 2020

Motivation for this change

awk.tar.gz can no longer be fetched from princeton.edu; The One True Awk is now on GitHub.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@konimex

@ofborg ofborg bot requested a review from konimex February 3, 2020 21:33
@alyssais
Copy link
Member

Is this an update to a release, or just to a git commit? If the latter, what’s the reason for updating?

@chkno
Copy link
Member Author

chkno commented Mar 13, 2020

Just to a recent git commit. The reason for updating is that the src url no longer exists.

@alyssais
Copy link
Member

alyssais commented Apr 1, 2020

In that case we should use the latest git tag.

@chkno
nawk: 20121220 -> 20200131
d1db950 
awk.tar.gz is no longer available from princeton.edu; The One True Awk
is now on GitHub.
@chkno chkno changed the title nawk: 20121220 -> 20200131 nawk: 20121220 -> 20180827 Apr 14, 2020
@chkno
Copy link
Member Author

chkno commented Apr 14, 2020

Done: Changed to latest (only) tag.

@ofborg ofborg bot requested a review from konimex April 14, 2020 18:54
@alyssais alyssais merged commit 8ff99ba into NixOS:master May 7, 2020
@alyssais
Copy link
Member

alyssais commented May 7, 2020

Fixed up the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@konimex konimex konimex approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @alyssais @doronbehar @konimex