vispy: init at 0.6.4 #79235

goertzenator · 2020-02-04T20:19:32Z

Motivation for this change

Add python module for vispy (scientific plotting) and freetype-py (needed by vispy).

Things done

FRidh · 2020-02-04T20:23:37Z

pkgs/development/python-modules/freetype-py/default.nix

+    })
+  ];
+
+  buildInputs = [ setuptools_scm ];


nativeBuildInputs

updated as requested

FRidh · 2020-02-04T20:24:42Z

pkgs/development/python-modules/vispy/default.nix

+  ];
+
+  buildInputs = [
+    cython setuptools setuptools_scm setuptools-scm-git-archive pyqt4


aside from pyqt4 the others likely belong in nativeBuildInputs. setuptools should not be here, unless it's needed at runtime in which case it should be in propagatedBuildInputs

updated as requested, setuptools and pyqt4 removed (pyqt4 was part of a failed effort to make tests work.)

jonringer

mostly LGTM.

Can you add yourself as a maintainer of the packages?
Also, can you try to add unit tests (if possible). Don't need 100% of the test suite, they just help when bumping dependencies and ensure something doesn't break.

jonringer · 2020-02-17T03:02:23Z

pkgs/development/python-modules/vispy/default.nix

+  doCheck = false;  # otherwise runs OSX code on linux.
+
+  meta = with lib; {
+    homepage = http://vispy.org/index.html;


Suggested change

homepage = http://vispy.org/index.html;

homepage = "http://vispy.org/index.html";

jonringer · 2020-02-17T03:02:52Z

pkgs/development/python-modules/freetype-py/default.nix

+  propagatedBuildInputs = [ freetype ];
+
+  meta = with lib; {
+    homepage = https://github.com/rougier/freetype-py;


Suggested change

homepage = https://github.com/rougier/freetype-py;

homepage = "https://github.com/rougier/freetype-py";

aanderse · 2020-03-26T02:56:48Z

(triage) ping @goertzenator

goertzenator · 2020-03-26T13:24:48Z

Thanks for reviewing, changes made as requested.

I ended up not using this package for my project so my interest in learning how to add unit tests is low. I did run vispy tests manually and there were lots of failures, but it did work for my brief experiment. I suspect the failures are more about the maturity of the project than interaction with nixpkgs.

mjlbach · 2020-05-07T10:35:41Z

I'm interested in getting this merged. Is this just blocked by tests?

goertzenator · 2020-05-07T12:49:24Z

I don't know what is blocking it. I think it might be helpful if you tried this PR on your system and reported if it produced a working vispy or not.

FRidh · 2020-05-07T12:51:21Z

Please avoid merging Nixpkgs branches and instead rebase.

goertzenator · 2020-05-07T12:54:46Z

Apologies, I just hit buttons in the github UI to resolve a minor conflict. I didn't see any choices about how to manage it. I'll tidy this up on the command line.

That said, maybe some github settings need to be tweaked if those buttons are doing the wrong thing?

goertzenator · 2020-05-07T13:12:46Z

All cleaned up. I looked at the settings on one of my repos and unfortunately did not see any controls for the "Resolve Conflicts" button.

mjlbach · 2020-05-07T13:20:43Z

Currently having a slight issue...

shell.nix

{ pkgs ? import <nixpkgs> {} }:
  pkgs.mkShell {
    buildInputs = [
      pkgs.python3Packages.vispy
      pkgs.python3Packages.pyqt5
  ];
}

error msg

WARNING: Could not find the Qt platform plugin "xcb" in ""
WARNING: This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-org.kde.kwin.qpa.

Aborted (core dumped)

This is usually fixed by adding a wrapQtAppsHook https://nixos.wiki/wiki/Qt, I know vispy uses pyqt5 but not sure what's happening here.

goertzenator · 2020-05-07T13:26:15Z

Looking back at my shell.nix I note that I had pyqt4 instead of pyqt5.

mjlbach · 2020-05-07T13:32:18Z

@goertzenator Thanks! That seems to do it. strange, vispy should be compatible with PyQt5

mjlbach · 2020-05-07T18:34:36Z

Nevermind, I just tried again this morning and it seems to be working with PyQt5, i tried a dozen examples and they all seem to work. Thanks for the contribution!

jonringer

I would prefer unit tests, but this should suffice

jonringer · 2020-05-07T18:40:41Z

pkgs/development/python-modules/vispy/default.nix

+    numpy freetype-py fontconfig libGL
+  ];
+
+  doCheck = false;  # otherwise runs OSX code on linux.


Suggested change

doCheck = false; # otherwise runs OSX code on linux.

doCheck = false; # otherwise runs OSX code on linux.

pythonImportsCheck = [ "vispy" ];

jonringer · 2020-05-07T18:41:40Z

pkgs/development/python-modules/freetype-py/default.nix

+  nativeBuildInputs = [ setuptools_scm ];
+
+  propagatedBuildInputs = [ freetype ];
+


Suggested change

pythonImportsCheck = [ "freetype" ];

prusnak

Tested ACK

prusnak · 2020-07-17T14:27:01Z

@jonringer every suggested change has been applied, can we have this merged?

vispy: init at 0.6.4 (cherry picked from commit 1be9aa3)

goertzenator requested review from FRidh and jonringer as code owners February 4, 2020 20:19

ofborg bot added the 6.topic: python label Feb 4, 2020

FRidh reviewed Feb 4, 2020

View reviewed changes

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 4, 2020

goertzenator force-pushed the add_vispy branch from 5eda644 to 2d056a2 Compare February 4, 2020 21:09

jonringer reviewed Feb 17, 2020

View reviewed changes

ofborg bot added the 11.by: package-maintainer label Mar 26, 2020

goertzenator added 3 commits May 7, 2020 07:58

freetype-py: init at 2.1.0.post1

5142e21

vispy: init at 0.6.4

81bc4bb

quote homepage values, add self as maintainer

6adf626

goertzenator force-pushed the add_vispy branch from 6ec4d3d to 6adf626 Compare May 7, 2020 13:01

jonringer reviewed May 7, 2020

View reviewed changes

add pythonImportsCheck

5f57e9f

prusnak approved these changes Jun 13, 2020

View reviewed changes

adisbladis merged commit 1be9aa3 into NixOS:master Jul 21, 2020

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jul 21, 2020

Merge pull request NixOS#79235 from goertzenator/add_vispy

0d2b49a

vispy: init at 0.6.4 (cherry picked from commit 1be9aa3)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vispy: init at 0.6.4 #79235

vispy: init at 0.6.4 #79235

goertzenator commented Feb 4, 2020 •

edited

FRidh Feb 4, 2020

goertzenator Feb 4, 2020

FRidh Feb 4, 2020

goertzenator Feb 4, 2020

jonringer left a comment

jonringer Feb 17, 2020

jonringer Feb 17, 2020

aanderse commented Mar 26, 2020

goertzenator commented Mar 26, 2020

mjlbach commented May 7, 2020

goertzenator commented May 7, 2020

FRidh commented May 7, 2020

goertzenator commented May 7, 2020

goertzenator commented May 7, 2020

mjlbach commented May 7, 2020

goertzenator commented May 7, 2020 •

edited

mjlbach commented May 7, 2020 •

edited

mjlbach commented May 7, 2020

jonringer left a comment

jonringer May 7, 2020

jonringer May 7, 2020

prusnak left a comment

prusnak commented Jul 17, 2020

	homepage = http://vispy.org/index.html;
	homepage = "http://vispy.org/index.html";

	homepage = https://github.com/rougier/freetype-py;
	homepage = "https://github.com/rougier/freetype-py";

	doCheck = false; # otherwise runs OSX code on linux.
	doCheck = false; # otherwise runs OSX code on linux.
	pythonImportsCheck = [ "vispy" ];

		nativeBuildInputs = [ setuptools_scm ];

		propagatedBuildInputs = [ freetype ];

vispy: init at 0.6.4 #79235

vispy: init at 0.6.4 #79235

Conversation

goertzenator commented Feb 4, 2020 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aanderse commented Mar 26, 2020

goertzenator commented Mar 26, 2020

mjlbach commented May 7, 2020

goertzenator commented May 7, 2020

FRidh commented May 7, 2020

goertzenator commented May 7, 2020

goertzenator commented May 7, 2020

mjlbach commented May 7, 2020

shell.nix

error msg

goertzenator commented May 7, 2020 • edited

mjlbach commented May 7, 2020 • edited

mjlbach commented May 7, 2020

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prusnak left a comment

Choose a reason for hiding this comment

prusnak commented Jul 17, 2020

goertzenator commented Feb 4, 2020 •

edited

goertzenator commented May 7, 2020 •

edited

mjlbach commented May 7, 2020 •

edited