Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 1.9.0 -> 1.10.0 #79172

Merged
1 commit merged into from Feb 4, 2020
Merged

qutebrowser: 1.9.0 -> 1.10.0 #79172

1 commit merged into from Feb 4, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 3, 2020 •
edited

Motivation for this change

Regular version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (qutebrowser)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ebzzry and jagajaga February 3, 2020 19:12
@ghost
Copy link

ghost commented Feb 4, 2020

I built and tested this on NixOS x86_64.
Can anyone confirm that the darwin build failure is not introduced by these changes though?

@veprbl
Copy link
Member

veprbl commented Feb 4, 2020

@petabyteboy Yes, qt5.qtwebengine is broken on darwin, that's unrelated. Thanks for testing.

@ghost ghost merged commit 9635871 into NixOS:master Feb 4, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 4, 2020

Thank you

@rnhmjoj rnhmjoj deleted the qute branch April 7, 2020 12:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebzzry ebzzry Awaiting requested review from ebzzry

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @veprbl