Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hglib: fix tests #79202

Merged
merged 1 commit into from Feb 5, 2020
Merged

pythonPackages.hglib: fix tests #79202

merged 1 commit into from Feb 5, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 4, 2020 •
edited

Motivation for this change

Fixing hglib for #76677
https://hydra.nixos.org/job/nixpkgs/trunk/python37Packages.hglib.x86_64-linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Feb 4, 2020 

6 package built:
python27Packages.hglib python27Packages.hgsvn python37Packages.hglib python38Packages.hglib reposurgeon sourcehut.hgsrht

@ofborg ofborg bot requested a review from dfoxfranke February 4, 2020 06:02
jonringer
jonringer reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/hglib/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from dfoxfranke February 4, 2020 17:52
@veprbl veprbl merged commit 87c12d7 into NixOS:master Feb 5, 2020
@veprbl veprbl deleted the pr/hglib_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@dfoxfranke dfoxfranke Awaiting requested review from dfoxfranke

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @dfoxfranke @jonringer