Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.libXft: add color emoji rendering support #79176

Merged
merged 1 commit into from Feb 5, 2020
Merged

xorg.libXft: add color emoji rendering support #79176

merged 1 commit into from Feb 5, 2020

Conversation

worldofpeace
Copy link
Contributor

https://gitlab.freedesktop.org/xorg/lib/libxft/merge_requests/1

Motivation for this change

Fixes #69073

Things done

Haven't tested against an actual package, but it builds.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to the 20.03 milestone Feb 3, 2020
jtojnar
jtojnar approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, it fixes the crash.

@dasJ
Copy link
Member

dasJ commented Feb 3, 2020

@jtojnar It does mostly. But sometimes (for example when printing localized files with weird characters), it still crashes (happens about once or twice per week)

@dasJ
Copy link
Member

dasJ commented Feb 3, 2020

Looks like that:
image

@dtzWill
Copy link
Member

dtzWill commented Feb 5, 2020

FWIW, someone on the upstream issue mentioned that this change breaks some fallback behavior re:glyphs not in base font (CJK, often): https://gitlab.freedesktop.org/xorg/lib/libxft/merge_requests/1#note_402043 .

I haven't tested this, just wanted to make sure this wasn't missed (if indeed an issue for us).

Otherwise, looking forward to emoji color goodness in libXft soon! :)

@FRidh FRidh added this to WIP in Staging via automation Feb 5, 2020
@FRidh FRidh changed the base branch from master to staging February 5, 2020 09:35
@FRidh FRidh changed the base branch from staging to master February 5, 2020 09:38
@FRidh FRidh changed the base branch from master to staging February 5, 2020 09:38
@FRidh FRidh merged commit cf83cfb into NixOS:staging Feb 5, 2020
Staging automation moved this from WIP to Done Feb 5, 2020
@worldofpeace worldofpeace deleted the libxft-patch-bgra branch February 5, 2020 10:47
@worldofpeace
Copy link
Contributor Author

Thanks @FRidh for integrating this and so many other changes ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

Emoji Fonts Crash st
5 participants
@worldofpeace @dasJ @dtzWill @jtojnar @FRidh