Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-sdk: reduce output size #79250

Merged
merged 4 commits into from Feb 5, 2020
Merged

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Feb 5, 2020

Motivation for this change

Together, these changes reduce output size by 27% (45.5 MiB).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Both third_party/crcmod_osx and third_party/crcmod are only used in the
PYTHONPATH, and we already replace them with dependencies from nixpkgs.
This reduces output size by 4.5 MiB.
This reduces output size by 20 MiB.
This reduces output size by 21 MiB.
@flokli flokli merged commit 873e6a4 into NixOS:master Feb 5, 2020
@edef1c edef1c deleted the gcloud-sdk-size branch February 5, 2020 21:55
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 5, 2020
google-cloud-sdk: reduce output size
(cherry picked from commit 873e6a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants