Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.vertica-python: init at 0.10.2 #79214

Merged
merged 1 commit into from Feb 17, 2020

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Packaging Python module vertica-python in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not getting around to this earlier, was traveling, and it dropped off

diff LGTM
commit LGTM
has tests 👍

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79214
3 package built:
python27Packages.vertica-python python37Packages.vertica-python python38Packages.vertica-python

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.vertica-python python37Packages.vertica-python python38Packages.vertica-python

@jonringer jonringer merged commit 78c147c into NixOS:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants