Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72bc71cc9d0a
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3ed1719de2dc
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 5, 2020

  1. Fix immediate editing of reference constraints. 

    Before this commit, if immediate editing of constraints was enabled,
then when adding a reference constraint, an editor was incorrectly
opened.
    @vespakoen
    vespakoen authored Feb 5, 2020
    Copy the full SHA
    3ed1719 View commit details
Showing with 4 additions and 6 deletions.
  1. +4 −6 src/constraint.cpp
10 changes: 4 additions & 6 deletions src/constraint.cpp
View file
Original file line number Diff line number Diff line change
@@ -196,9 +196,6 @@ void Constraint::MenuConstrain(Command id) {
c.valA = 0;
c.ModifyToSatisfy();
AddConstraint(&c);
if (SS.immediatelyEditDimension) {
SS.GW.EditConstraint(c.h);
}
break;
}

@@ -610,9 +607,6 @@ void Constraint::MenuConstrain(Command id) {

c.ModifyToSatisfy();
AddConstraint(&c);
if (SS.immediatelyEditDimension) {
SS.GW.EditConstraint(c.h);
}
break;
}

@@ -769,6 +763,10 @@ void Constraint::MenuConstrain(Command id) {
}
}

if ((id == Command::DISTANCE_DIA || id == Command::ANGLE) && SS.immediatelyEditDimension) {
SS.GW.EditConstraint(c.h);
}

SS.GW.ClearSelection();
}