Adding Dell XPS 15 9560 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything left to do here? |
|
I need to test it and make it ready for review. :)) |
|
Did you had the chance to test it? |
1 default one, with nvidia working and intel working, needs optirun to run application with nvidia 2 intel only, I am using this as my daily driver for long time, only intel is turned on and nvidia is turned off and doesn't drain any power. 3 nvidia only, intel is dissabled and nvidia is picked as default gpu, no need to fiddle with optirun etc, good for gpu heavy application. All these settings needs to reboot to work properly
|
I tested the default, nvidia and intel configuration and on my laptop everything works as intended. You can merge. :)) |
|
Could you restart the checks, because it run out of memory that is not related to my pull request. or am I wrong ? |
|
Yes. The travis failure is unrelated to your change. I will ignore it for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add xps 9560 with its own quirks, I added versions:
1 default one, with nvidia working and intel working, needs optirun to
run application with nvidia
2 intel only, I am using this as my daily driver for long time, only
intel is turned on and nvidia is turned off and doesn't drain any
power.
3 nvidia only, intel is dissabled and nvidia is picked as default gpu,
no need to fiddle with optirun etc, good for gpu heavy application.
All these settings needs to reboot to work properly.