Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifmetric: init at 0.3 #79186

Merged
merged 1 commit into from Aug 10, 2020
Merged

ifmetric: init at 0.3 #79186

merged 1 commit into from Aug 10, 2020

Conversation

anna328p
Copy link
Member

@anna328p anna328p commented Feb 3, 2020

Motivation for this change

Adds ifmetric, a tool for setting network interface metrics, to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@anna328p
Copy link
Member Author

@GrahamcOfBorg eval

jonringer
jonringer reviewed May 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/os-specific/linux/ifmetric/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/ifmetric/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@anna328p
Copy link
Member Author

Rebased on latest master.

@anna328p
Copy link
Member Author

@jonringer I have addressed all of your comments and updated the commit.

jonringer
jonringer approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/79186
1 package built:
ifmetric

looks to be largely unmaintained, but I don't see any more "up-to-date" alternatives

@jonringer jonringer merged commit 0500296 into NixOS:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anna328p @jonringer