Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b8a8fd0fd52f
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f40a8a09fb97
Choose a head ref
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 4, 2020

  1. common-updater-scripts: mention --ignore-same-hash in usage

    @jtojnar
    jtojnar committed Feb 4, 2020
    Copy the full SHA
    ea9da64 View commit details
    Browse the repository at this point in the history

  2. common-updater-scripts: Support SRI-style hash 

    Some fetcher functions support SRI-style `hash` attribute in addition to legacy type-specific attributes. When `hash` is used `outputHashAlgo` is null so let’s complain when SRI-style hash value was not detected.

Such attributes match the form ${type}${separator}${hash}: True SRI uses dash as a separator and only supports base64, whereas Nix’s SRI-style format uses a colon and supports all the same encodings like regular hashes (16/32/64).

To keep this program reasonably simple, we will upgrade Nix’s SRI-like format to pure SRI instead of preserving it.
    @jtojnar
    jtojnar committed Feb 4, 2020
    Copy the full SHA
    5a1bc70 View commit details
    Browse the repository at this point in the history

  3. common-updater-scripts: clean up 

    Fix issues reported by shellcheck and few other style issues.

Though we need to ignore $systemArg complaints because Nix does not support passing --system as a single argument.
    @jtojnar
    jtojnar committed Feb 4, 2020
    Copy the full SHA
    65543d1 View commit details
    Browse the repository at this point in the history

  4. common-updater-scripts: move destructive changes further in the script 

    We can check some things before the modifications take place.
    @jtojnar
    jtojnar committed Feb 4, 2020
    Copy the full SHA
    e4a0953 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #78913 from jtojnar/cus-fixes 

    common-updater-scripts: Support SRI-style hash
    @jtojnar
    jtojnar committed Feb 4, 2020
    Copy the full SHA
    f40a8a0 View commit details
    Browse the repository at this point in the history