Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beamPackages.hex: 0.20.1 -> 0.20.5 #79203

Merged
merged 1 commit into from Feb 24, 2020
Merged

beamPackages.hex: 0.20.1 -> 0.20.5 #79203

merged 1 commit into from Feb 24, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Feb 4, 2020

Motivation for this change

Keeping things up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789 cw789 changed the title beamPackages.hex: 0.20.1 -> 0.20.4 beamPackages.hex: 0.20.1 -> 0.20.5 Feb 5, 2020
@cw789
Copy link
Contributor Author

cw789 commented Feb 5, 2020

cc @ericbmerritt

@cw789
Copy link
Contributor Author

cw789 commented Feb 24, 2020

Calling the Elixir maintainers:
@the-kenny @Havvy @couchemar @ankhers @filalex77

Hey guys, could anybody help me to get this merged?

Br1ght0ne
Br1ght0ne approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@Br1ght0ne
Copy link
Member

@cw789 Sadly, I don't have commit access. Pinging people who have :)

cc @marsam @yegortimoshenko. Thanks a lot!

@lukateras
Copy link
Member

lukateras commented Feb 24, 2020 •
edited 

/nix/store/c9bhvsszng7fawgmj2cn3fq12zr320y3-hex-0.20.5

@lukateras
Copy link
Member

@GrahamcOfBorg build beamPackages.hex beamPackages.pc

@lukateras lukateras merged commit 8cf6d49 into NixOS:master Feb 24, 2020
@cw789 cw789 deleted the hex_update branch February 25, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cw789 @Br1ght0ne @lukateras