Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locate: Clarify mlocate warning message #79239

Merged
merged 1 commit into from Aug 25, 2020
Merged

locate: Clarify mlocate warning message #79239

merged 1 commit into from Aug 25, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Feb 4, 2020

Motivation for this change

Make it clear that the warning is that updatedb will run as root, not that locate will only run as root. Also explain how to silence the warning.

Fixes #30864.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cc @gkleen

@andersk
locate: Clarify mlocate warning message
db28ce3 
Make it clear that the warning is that updatedb will run as root, not
that locate will only run as root.  Also explain how to silence the
warning.

Fixes NixOS#30864.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from Valodim March 25, 2020 20:33
@andersk andersk mentioned this pull request Aug 6, 2020
Closed
@unode
Copy link
Member

unode commented Aug 6, 2020

This has been pending for half a year and is a harmless merge.
Can someone with permission do the final step?

Thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/208

@AndersonTorres AndersonTorres merged commit 213c004 into NixOS:master Aug 25, 2020
@andersk andersk deleted the mlocate-warning branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_merger needs_merger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mlocate incorrectly warns about lack of user support
5 participants
@andersk @unode @nixos-discourse @Valodim @AndersonTorres