Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urweb: Fix icu headers include path #79219

Merged
merged 1 commit into from Feb 5, 2020
Merged

urweb: Fix icu headers include path #79219

merged 1 commit into from Feb 5, 2020

Conversation

turboMaCk
Copy link
Member

Since #62266
urweb fails to resolve <unicode/utypepes.h> in runtime (during
compilation of project).
upstream commit: urweb/urweb@c2a217f

resolves #79218

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @thoughtpolice @sheganinans

turboMaCk
turboMaCk commented Feb 4, 2020
View reviewed changes
pkgs/development/compilers/urweb/default.nix
@@ -23,6 +23,7 @@ stdenv.mkDerivation rec {
export PGHEADER="${postgresql}/include/libpq-fe.h";
export MSHEADER="${libmysqlclient}/include/mysql/mysql.h";
export SQHEADER="${sqlite.dev}/include/sqlite3.h";
export ICU_INCLUDES="-I${icu.dev}/include";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For quick crosschecking see configure script in upstream:

https://github.com/urweb/urweb/blob/master/configure.ac#L94-L98

@ofborg ofborg bot requested a review from thoughtpolice February 4, 2020 12:53
@turboMaCk
urweb: Fix icu headers include path
4e69593 
Since NixOS#62266
urweb fails to resolve <unicode/utypepes.h> in runtime (during
compilation of project).
upstream commit: urweb/urweb@c2a217f

resolves NixOS#79218
@thoughtpolice thoughtpolice merged commit 6d1e9c0 into NixOS:master Feb 5, 2020
@turboMaCk turboMaCk deleted the urweb-icu-fix branch February 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urweb: runtime include icu headers.
3 participants
@turboMaCk @thoughtpolice @jtojnar