haskellPackages.idris: Fix build (new GHC 8.8 & old megaparsec 7) #84131
Conversation
ofborg
bot
added
6.topic: haskell
8.has: package (new)
| (super.idris.override { megaparsec = self.megaparsec_7_0_5; }) [ | ||
| (pkgs.fetchpatch { | ||
| url = "https://github.com/idris-lang/Idris-dev/pull/4808.diff"; | ||
| sha256 = "060ib1rczy34ip8xf3bv1pf28655f6s0bvvij19jhh5dpcr0pf71"; | ||
| excludes = [ ".travis.yml" "Makefile" "appveyor.yml" ]; | ||
| }) |
There was a problem hiding this comment.
Could you add a comment to both the override and the fetchpatch lines describing why they are needed, linking to any relevant upstream issues/PRs, and adding a guess about when they can be removed (when a new upstream version is released??).
Also, please rebase this onto haskell-updates and change the base branch on Github to haskell-updates.
The hackage-packages.nix change was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@ad4a70d.
|
LGTM, thanks for updating this |
| "megaparsec_7_0_5" = callPackage | ||
| ({ mkDerivation, base, bytestring, case-insensitive, containers | ||
| , criterion, deepseq, mtl, parser-combinators, scientific, text | ||
| , transformers, weigh | ||
| }: | ||
| mkDerivation { | ||
| pname = "megaparsec"; | ||
| version = "7.0.5"; | ||
| sha256 = "0bqx1icbmk8s7wmbcdzsgnlh607c7kzg8l80cp02dxr5valjxp7j"; | ||
| libraryHaskellDepends = [ | ||
| base bytestring case-insensitive containers deepseq mtl | ||
| parser-combinators scientific text transformers | ||
| ]; | ||
| benchmarkHaskellDepends = [ | ||
| base containers criterion deepseq text weigh | ||
| ]; | ||
| description = "Monadic parser combinators"; | ||
| license = stdenv.lib.licenses.bsd2; | ||
| hydraPlatforms = stdenv.lib.platforms.none; | ||
| }) {}; |
There was a problem hiding this comment.
@peti I know we normally don't commit these changes to hackage-packages.nix in PRs, but I was thinking that the daily automatic update should just overwrite this, so there won't be any sort of problems with merge conflicts or anything.
If I was wrong about this (and there does end up being problems), please let me know.
Motivation for this change
Make idris work.
(This is distinct from #53406, a previous time a megaparsec update broke idris. That was about megaparsec 6→7. This is about megaparsec 7→8. Upstream project has declared that it plans to stay on megaparsec 7 indefinitely.)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@infinisil