[20.03] mariadb: backport updates #84164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @flokli |
|
@GrahamcOfBorg build mariadb.client |
flokli
changed the title
|
@Izorkin the PR was targeted against another branch, and now needs a rebase. I'm doing that now. |
(cherry picked from commit c6d159d)
(cherry picked from commit 982a23d)
When used as a global override, it breaks most of the options in the mysql module, such as ensureDatabases, ensureUsers, initialDatabases, initialScript. We could use `.client` there, but if the reasoning behind this was closure size reduction, we now end up with the same (or a bigger) runtime closure and more complexity. Apart from the options exposed by the mysql module, the client is also likely to be required for local backups or DBA tasks anyways. Instead of dealing with all the increased complexity of this for no arguable benefit, let's just remove the `withoutClient` argument. Storage space on mysql servers shouldn't be that much of an issue. Closes NixOS#82428. (cherry picked from commit 4b8d66a)
(cherry picked from commit 0296e67)
(cherry picked from commit eafdfc8)
(cherry picked from commit 2435743)
(cherry picked from commit 5abc729)
flokli
force-pushed
the
mariadb-tokudb-20.03
branch
from
6e48070
to
c0c04ea
Compare
|
Did that now, also had to manually add the
line usually created from the Pleas remember to always to backport cherrypicks with this parameter. |
Sorry, i will try not to forget. |
aanderse
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport updates to 20.03
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)