Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xonotic: use svg icons #84162

Merged
merged 1 commit into from Apr 14, 2020
Merged

xonotic: use svg icons #84162

merged 1 commit into from Apr 14, 2020

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Apr 3, 2020 •
edited

Motivation for this change

Add desktop entries to Xonotic.

Use SVG icons in Xonotic. (I first did a bit larger PR but most of it had already been done, so this minor suggestion was left.)

cc: maintainers @astsmtl @umazalakain

By the way, xonotic-glx is failing on my machine:

Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Desired video mode fail, trying fallbacks...
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Loading OpenGL driver libGL.so.1
Unable to open symbol list for libGL.so.1
Unable to load GL driver "libGL.so.1"
Quake Error: Video modes failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine
Copy link
Member Author

jluttine commented Apr 3, 2020

Oh, something like this had already been done in master 11h ago, so I didn't spot it. Hmm.. I could propose a few minor changes to the current desktop entry though.

@jluttine
Copy link
Member Author

jluttine commented Apr 3, 2020

I now completely rewrote my PR. Now it's very minor but I thought I offer it anyway. It uses SVG icons instead of raster ones and adds Shooter to desktop entry categories. I checked Shooter is a real valid sub-category in the specification: https://specifications.freedesktop.org/menu-spec/latest/apas02.html

@jluttine jluttine changed the title xonotic: add desktop entries xonotic: use svg icons Apr 3, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/some-app-cant-start-with-couldnt-find-matching-glx-visual/6508/4

@worldofpeace worldofpeace merged commit 9c7486f into NixOS:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @nixos-discourse @worldofpeace