-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
linuxPackages.nvidia_x11: 440.59 -> 440.64 #84163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc. @baracoder |
5b392d7
to
ca5093e
Compare
There is a similar PR #81454 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine, but what about #81454 (comment), is it still needed?
As far as I can tell 440.64 only unbreaks with kernel 5.6-rc1, and not the actual release. Patches still seem necessary? |
ca5093e
to
1240932
Compare
@GrahamcOfBorg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with different kernel versions, all building fine
linuxPackages_4_4.nvidia_x11
linuxPackages_4_19.nvidia_x11
linuxPackages_latest.nvidia_x11 (5.6.2)
e969c3c
to
bcd4f1e
Compare
bcd4f1e
to
408de50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nixpkgs-review on NixOS (x86_64-linux):
4 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_beta linuxPackages_hardkernel_latest.nvidia_x11 linuxPackages_hardkernel_latest.nvidia_x11_beta
7 package failed to build:
haskellPackages.cuda linuxPackages_testing_bcachefs.nvidia_x11 python27Packages.TheanoWithCuda python27Packages.cupy python37Packages.TheanoWithCuda python37Packages.tensorflowWithCuda python38Packages.TheanoWithCuda
22 package built:
bumblebee linuxPackages-libre.nvidia_x11 linuxPackages.nvidia_x11 linuxPackages_4_14.nvidia_x11 linuxPackages_4_19.nvidia_x11 linuxPackages_4_4.nvidia_x11 linuxPackages_4_9.nvidia_x11 linuxPackages_5_5.nvidia_x11 linuxPackages_5_6.nvidia_x11 linuxPackages_hardened.nvidia_x11 linuxPackages_latest-libre.nvidia_x11 linuxPackages_latest_hardened.nvidia_x11 linuxPackages_latest_xen_dom0.nvidia_x11 linuxPackages_latest_xen_dom0_hardened.nvidia_x11 linuxPackages_testing_hardened.nvidia_x11 linuxPackages_xen_dom0.nvidia_x11 linuxPackages_xen_dom0_hardened.nvidia_x11 nvtop primus psensor python37Packages.cupy python38Packages.cupy
(cherry picked from commit 408de50) cc NixOS#84163
Motivation for this change
Unbreaks nvidia with kernel 5.6.x
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)