Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.nvidia_x11: 440.59 -> 440.64 #84163

Merged
merged 1 commit into from Apr 6, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Unbreaks nvidia with kernel 5.6.x

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

cc. @baracoder

@veprbl veprbl requested review from eadwu and baracoder April 3, 2020 07:16
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 3, 2020
@baracoder
Copy link
Contributor

There is a similar PR #81454

Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine, but what about #81454 (comment), is it still needed?

@arcnmx
Copy link
Member

arcnmx commented Apr 3, 2020

Unbreaks nvidia with kernel 5.6.x

As far as I can tell 440.64 only unbreaks with kernel 5.6-rc1, and not the actual release. Patches still seem necessary?

@lovesegfault
Copy link
Member Author

@arcnmx @eadwu Should be fixed :)

@lovesegfault
Copy link
Member Author

@GrahamcOfBorg eval

Copy link
Contributor

@baracoder baracoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with different kernel versions, all building fine
linuxPackages_4_4.nvidia_x11
linuxPackages_4_19.nvidia_x11
linuxPackages_latest.nvidia_x11 (5.6.2)

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nixpkgs-review on NixOS (x86_64-linux):

4 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_beta linuxPackages_hardkernel_latest.nvidia_x11 linuxPackages_hardkernel_latest.nvidia_x11_beta

7 package failed to build:
haskellPackages.cuda linuxPackages_testing_bcachefs.nvidia_x11 python27Packages.TheanoWithCuda python27Packages.cupy python37Packages.TheanoWithCuda python37Packages.tensorflowWithCuda python38Packages.TheanoWithCuda

22 package built:
bumblebee linuxPackages-libre.nvidia_x11 linuxPackages.nvidia_x11 linuxPackages_4_14.nvidia_x11 linuxPackages_4_19.nvidia_x11 linuxPackages_4_4.nvidia_x11 linuxPackages_4_9.nvidia_x11 linuxPackages_5_5.nvidia_x11 linuxPackages_5_6.nvidia_x11 linuxPackages_hardened.nvidia_x11 linuxPackages_latest-libre.nvidia_x11 linuxPackages_latest_hardened.nvidia_x11 linuxPackages_latest_xen_dom0.nvidia_x11 linuxPackages_latest_xen_dom0_hardened.nvidia_x11 linuxPackages_testing_hardened.nvidia_x11 linuxPackages_xen_dom0.nvidia_x11 linuxPackages_xen_dom0_hardened.nvidia_x11 nvtop primus psensor python37Packages.cupy python38Packages.cupy

@veprbl veprbl merged commit 9b0d2f3 into NixOS:master Apr 6, 2020
veprbl pushed a commit that referenced this pull request Apr 6, 2020
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 6, 2020
@lovesegfault lovesegfault deleted the nvidia-x11-440.64 branch April 7, 2020 07:32
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants