llvmPackages_latest: llvm9->llvm10 #84096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
10 tasks
ggreif
reviewed
Apr 5, 2020
pkgs/top-level/all-packages.nix
Outdated
| llvm-polly = llvmPackages_latest.llvm-polly; | ||
| clang-polly = llvmPackages_latest.clang.override { cc = llvmPackages_latest.clang-polly-unwrapped; }; | ||
|
|
||
| # llvm and clang are build with polly by default |
There was a problem hiding this comment.
Suggested change
| # llvm and clang are build with polly by default | |
| # llvm and clang are built with polly by default |
There was a problem hiding this comment.
After looking how this is usually done, I changed the lines to use throw. This prevents llvm-polly/clang-polly, but also provides an error message to the user. I think this is the best solution.
Thanks for finding the typo :)
|
I guess this should be |
|
This causes almost no rebuilds, because |
since llvm10 is now the newest release now throws an error if llvm-polly or clang-polly is build, since polly is enabled by default.
DieGoldeneEnte
force-pushed
the
llvm-latest
branch
from
b8a6b81
to
c4afa32
Compare
Mic92
reviewed
Apr 13, 2020
pkgs/top-level/all-packages.nix
Outdated
| clang-polly = llvmPackages_latest.clang.override { cc = llvmPackages_latest.clang-polly-unwrapped; }; | ||
|
|
||
| llvm-polly = throw "clang is now built with polly-plugin by default"; | ||
| clang-polly = throw "clang is now built with polly-plugin by default"; |
There was a problem hiding this comment.
Put this in pkgs/top-level/aliases.nix with a timestamp.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since llvm10 is now the newest release.
This also sets llvm-polly and clang-polly to normal llvm/clang, since polly is now enabled by default.
Maybe we want to remove the
-pollyvariants at some point in the future?The only affected packages are:
Things done
The tiledb python module has tests failing, but this is unrelated to llvm (see #84091 for more information).
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)