Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9548a495d5f2
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1c1ccc8c7e04
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 2, 2020

  1. Provide some debug info for if posting a status update fails

    @grahamc
    grahamc committed Apr 2, 2020
    Copy the full SHA
    1c1ccc8 View commit details
Showing with 12 additions and 5 deletions.
  1. +12 −5 ofborg/src/tasks/evaluate.rs
17 changes: 12 additions & 5 deletions ofborg/src/tasks/evaluate.rs
View file
Original file line number Diff line number Diff line change
@@ -221,16 +221,23 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> {
update_labels(&issue_ref, &[String::from("ofborg-internal-error")], &[]);
}
EvalWorkerError::EvalError(eval::Error::Fail(msg)) => {
self.update_status(msg, None, hubcaps::statuses::State::Failure)
.expect("Failed to set status");
self.update_status(msg.clone(), None, hubcaps::statuses::State::Failure)
.unwrap_or_else(|e| {
panic!("Failed to set plain status: {}; e: {:#?}", msg, e);
});
}
EvalWorkerError::EvalError(eval::Error::FailWithGist(msg, filename, content)) => {
self.update_status(
msg,
self.make_gist(&filename, Some("".to_owned()), content),
msg.clone(),
self.make_gist(&filename, Some("".to_owned()), content.clone()),
hubcaps::statuses::State::Failure,
)
.expect("Failed to set status");
.unwrap_or_else(|e| {
panic!(
"Failed to set status with a gist: {}, {}, {}; e: {:#?}",
msg, filename, content, e
);
});
}
}