Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] chromium: 80.0.3987.149 -> 80.0.3987.163 (backport) #84107

Merged
merged 4 commits into from Apr 3, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 2, 2020

Motivation for this change

Backport of #83956 (edit: fixed the reference).

Testing status
platform attribute status tester
x86_64 chromium ✔️ @Frostman
x86_64 nixosTests.chromium ✔️ @Frostman
x86_64 google-chrome ✔️ @primeos
aarch64 chromium - -
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 3 commits April 2, 2020 15:21
The webrtc code suffered from a race condition when used
with Pulseaudio. This lead to audio input breaking every
couple of minutes during a webrtc session.

(cherry picked from commit 81b18c3)
@Frostman
Copy link
Member

Frostman commented Apr 2, 2020

chromium tests passed ok (x86_64)

https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop.html

Note: This update contains only two fixes [0]. The fix that reverts a
feature which caused a crash spike on 80.0.3987.162 [1] seems important
for us (though the commit doesn't provide any data on the crash spike).

[0]: https://chromium.googlesource.com/chromium/src/+log/80.0.3987.162..80.0.3987.163?pretty=fuller
[1]: https://chromium.googlesource.com/chromium/src/+/fc11c43603c05a9ef77430a6b4081a01969d2bf4

(cherry picked from commit cbd13f3)
@primeos primeos changed the title [19.09] chromium: 80.0.3987.149 -> 80.0.3987.162 (backport) [19.09] chromium: 80.0.3987.149 -> 80.0.3987.163 (backport) Apr 3, 2020
@Frostman
Copy link
Member

Frostman commented Apr 3, 2020

chromium tests are still passing (with -> .163 commit)

@primeos primeos merged commit 6ce362a into NixOS:release-19.09 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants