Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseeffects: 4.7.1 -> 4.7.2 #84186

Merged
merged 3 commits into from Apr 3, 2020
Merged

pulseeffects: 4.7.1 -> 4.7.2 #84186

merged 3 commits into from Apr 3, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Depends on #84182

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
boost: init at 1.72.0
c028978 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
boost17x: boost171 -> boost172
4458697 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
pulseeffects: 4.7.1 -> 4.7.2
fb818c5 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

See wwmm/easyeffects#645 for why this depends on boost 1.72!

@ofborg ofborg bot requested a review from jtojnar April 3, 2020 12:39
@Ma27 Ma27 merged commit 470b916 into NixOS:master Apr 3, 2020
@matthiasbeyer matthiasbeyer deleted the update-pulseeffects branch April 3, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasbeyer @Ma27