Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmapshack: add gdal/routino tools to PATH #84145

Merged
merged 1 commit into from May 29, 2020
Merged

qmapshack: add gdal/routino tools to PATH #84145

merged 1 commit into from May 29, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Apr 3, 2020

Motivation for this change

Fixes runtime errors:

  • Unable to find Routino's planetslitter. Searched for "planetsplitter" and "routino-planetsplitter".
  • No "gdal_translate" found. Please check setup!
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dotlambda April 3, 2020 00:48
@sikmir
Copy link
Member Author

sikmir commented May 7, 2020

@FRidh Could you please take a look at this PR?

@sikmir
Copy link
Member Author

sikmir commented May 14, 2020

@dywedir Could you please help with landing this PR?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/174

@marsam marsam merged commit e6f4426 into NixOS:master May 29, 2020
@sikmir sikmir deleted the qmapshack branch May 29, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @nixos-discourse @marsam