Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gthumb: add gst plugins and needed environment for video playbacl #84092

Merged
merged 1 commit into from Apr 2, 2020
Merged

gthumb: add gst plugins and needed environment for video playbacl #84092

merged 1 commit into from Apr 2, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 2, 2020 •
edited

Motivation for this change

Fix #43551

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Apr 2, 2020
Closed
@ofborg ofborg bot requested a review from mimame April 2, 2020 09:37
bjornfor
bjornfor requested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nitpick: (1) commit message typo (playbacl -> playback) and "needed environment" doesn't apply anymore.

@doronbehar doronbehar requested a review from bjornfor April 2, 2020 15:00
@bjornfor bjornfor merged commit 044dfab into NixOS:master Apr 2, 2020
@bjornfor
Copy link
Contributor

bjornfor commented Apr 2, 2020

Thanks!

@doronbehar doronbehar deleted the improve-gthumb branch March 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@bjornfor bjornfor bjornfor approved these changes

@mimame mimame Awaiting requested review from mimame

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gthumb does not play videos
3 participants
@doronbehar @bjornfor @jtojnar