Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/teams: add podman team #84177

Merged
merged 9 commits into from Apr 9, 2020
Merged

maintainers/teams: add podman team #84177

merged 9 commits into from Apr 9, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 3, 2020

Initial discussion in #84168 (comment)

cc @saschagrunert @vdemeester

vdemeester
vdemeester approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

saschagrunert
saschagrunert approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FRidh
Copy link
Member

FRidh commented Apr 3, 2020

Good to see more maintainer teams!

@FRidh
Copy link
Member

FRidh commented Apr 3, 2020

Could you give feedback on #75275? I assume you use those builders.

@jtojnar jtojnar merged commit bbb299c into NixOS:master Apr 9, 2020
@zowoq zowoq deleted the team branch April 9, 2020 12:04
@worldofpeace
Copy link
Contributor

Added a @NixOS/podman team for all of you.
(and did invites)

@zowoq
Copy link
Contributor Author

zowoq commented Apr 29, 2020 •
edited

Seems like some of the teams don't work for requesting reviews?

NixOS/{acme,freedesktop,gnome} are able to be used but can't select podman/php?

@worldofpeace
Copy link
Contributor

@zowoq I asked @grahamc to add nixpkgs to the repos' (since you have to be a admin to do this)

@zowoq
Copy link
Contributor Author

zowoq commented May 14, 2020

@zowoq I asked @grahamc to add nixpkgs to the repos' (since you have to be a admin to do this)

Ping @grahamc

Also, I noticed that some teams have a profile picture set, could we add the podman logo please?

podman

@zowoq zowoq mentioned this pull request May 16, 2020
Merged
@zowoq zowoq mentioned this pull request May 27, 2020
Merged
@grahamc
Copy link
Member

grahamc commented May 27, 2020

done!

@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zowoq @FRidh @worldofpeace @grahamc @vdemeester @saschagrunert @jtojnar