Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swaylock-effects: init at v1.6-0 #84178

Merged
merged 2 commits into from Apr 3, 2020
Merged

swaylock-effects: init at v1.6-0 #84178

merged 2 commits into from Apr 3, 2020

Conversation

gnxlxnxx
Copy link
Contributor

@gnxlxnxx gnxlxnxx commented Apr 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
Copy link
Member

Emantor commented Apr 3, 2020

Testing on NixOS unstable with the waylandOverlay (sway-git, wlroots-git), all the effects give me is a white screen and the usual unlock indicator, I tested --effect-greyscale and --effect-blur.

@gnxlxnxx
Copy link
Contributor Author

gnxlxnxx commented Apr 3, 2020

yeah you have to either --screenshot or --image

Emantor
Emantor approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you have to either --screenshot or --image

Indeed, that works.

@Ma27 Ma27 merged commit c7b9c4e into NixOS:master Apr 3, 2020
@evils evils mentioned this pull request May 19, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnxlxnxx @Emantor @Ma27 @Janik-Haag