Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cvxpy: add explicit numpy/scipy dependencies #84120

Merged
merged 1 commit into from Apr 3, 2020
Merged

pythonPackages.cvxpy: add explicit numpy/scipy dependencies #84120

merged 1 commit into from Apr 3, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add explicit numpy/scipy dependencies, based on https://www.cvxpy.org/install/#install-from-source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Says NO DIFF.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.cvxpy: explicit numpy/scipy
53b803e 
Make numpy/scipy dependencies explicit, based on conda install
instructions for cvxpy.
Slight formatting fix.
bcdarwin
bcdarwin approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drewrisinger
Copy link
Contributor Author

Note: borg won't build it due to upstream unfree mkl dependency, which will be fixed in #84124. Builds locally.

nixpkgs-review pr 84120
#84120
6 package built:
python37Packages.cvxpy python37Packages.qiskit-aer python37Packages.qiskit-ignis python38Packages.cvxpy python38Packages.qiskit-aer python38Packages.qiskit-ignis

bhipple
bhipple approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 84120 1

6 package built: - python37Packages.cvxpy - python37Packages.qiskit-aer - python37Packages.qiskit-ignis - python38Packages.cvxpy - python38Packages.qiskit-aer - python38Packages.qiskit-ignis

@bhipple bhipple merged commit c51ba89 into NixOS:master Apr 3, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 3, 2020

Can you send a 20.03 backport PR as well?

@drewrisinger drewrisinger deleted the dr-pr-cvxpy-fix branch April 3, 2020 22:05
@drewrisinger
Copy link
Contributor Author

@bhipple same for cvxpy, not in release-20.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @bhipple @bcdarwin