Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buku: 4.2.2 -> 4.3, introduce new dependency #84097

Merged
merged 2 commits into from Apr 7, 2020
Merged

buku: 4.2.2 -> 4.3, introduce new dependency #84097

merged 2 commits into from Apr 7, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Apr 2, 2020

@GrahamcOfBorg eval
#83529

@ofborg ofborg bot requested a review from infinisil April 2, 2020 11:57
Br1ght0ne
Br1ght0ne approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
buku --help works

[6 built, 92 copied (147.0 MiB), 26.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84097
3 package built:
buku python37Packages.flask-reverse-proxy-fix python38Packages.flask-reverse-proxy-fix

@matthiasbeyer
python3Packages.flask-reverse-proxy-fix: init at 0.2.1
ef47974 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
buku: 4.2.2 -> 4.3
43eef47 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
jonringer
jonringer approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/84097
3 package built:
buku python37Packages.flask-reverse-proxy-fix python38Packages.flask-reverse-proxy-fix

@jonringer jonringer merged commit b9b3cdf into NixOS:master Apr 7, 2020
@matthiasbeyer matthiasbeyer deleted the update-buku branch April 7, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiasbeyer @timokau @jonringer @Br1ght0ne