Skip to content

nixos/moinmoin: fix maintainer reference #84103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

nixos/moinmoin: fix maintainer reference #84103

merged 1 commit into from
Apr 2, 2020
+1 −1

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Apr 2, 2020

Due to a race condition in PR review the moinmoin module refers to my IRC nick which is not what is in maintainers.nix. cc @infinisil

Motivation for this change
02:31 <infinisil> > :p nixos.config.meta.maintainers
02:31 <nix-build> undefined variable 'b42' at /var/lib/nixbot/nixpkgs/master/repo/nixos/modules/services/web-apps/moinmoin.nix:302:46

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 2, 2020
@infinisil infinisil merged commit 4985935 into NixOS:master Apr 2, 2020
@mmilata mmilata mentioned this pull request Apr 2, 2020
Merged
@mmilata mmilata deleted the moinmoin-b42 branch April 2, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @infinisil