Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: 0.21.0-1 -> 0.21.1 #84170

Merged
merged 1 commit into from Apr 3, 2020
Merged

fzf: 0.21.0-1 -> 0.21.1 #84170

merged 1 commit into from Apr 3, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 3, 2020

https://github.com/junegunn/fzf/blob/master/CHANGELOG.md#0211

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne, kalbasit and Ma27 April 3, 2020 08:58
@Ma27 Ma27 merged commit 3315767 into NixOS:master Apr 3, 2020
@zowoq zowoq deleted the fzf branch April 3, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Ma27