Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipit: 1.4.2 -> 1.4.4 #84111

Merged
merged 1 commit into from Apr 2, 2020
Merged

clipit: 1.4.2 -> 1.4.4 #84111

merged 1 commit into from Apr 2, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 2, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Apr 2, 2020
Closed
9 tasks
@Emantor
Copy link
Member

Emantor commented Apr 2, 2020

Builds fine, but crashes immediately under wayland (sway), known issue, see CristianHenzel/ClipIt#130.

@Mic92
Copy link
Member Author

Mic92 commented Apr 2, 2020 •
edited

Did crash before or was it useful in wayland? I assume x11 clipboards are not available in wayland in the same way.

@Emantor
Copy link
Member

Emantor commented Apr 2, 2020

I saw the dialog which asked me if I want to save the history in a file once, afterwards the segfault is consistent. IMO LGTM, should nevertheless work on X11.

@Mic92 Mic92 merged commit d6d87e6 into NixOS:master Apr 2, 2020
@Mic92 Mic92 deleted the clipit branch April 2, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Emantor