mirage: init at 0.5.1 #84150

colemickens · 2020-04-03T01:14:20Z

Motivation for this change

Package new application mirage as attribute mirage-im (there's an existing alias, maybe I could remove it?).

This is a draft since the application doesn't work yet.

This fixes #84147.

Things done

doronbehar

This is a draft since the application doesn't work yet.

What happens when you run it from the command line?

doronbehar · 2020-04-03T08:20:08Z

pkgs/applications/networking/instant-messengers/mirage/default.nix

@@ -0,0 +1,30 @@
+{ mkDerivation, stdenv, lib, fetchFromGitHub, cmake, qtbase, qtquickcontrols2
+, qtkeychain, qtmultimedia, qttools, libqmatrixclient_0_5, libQuotient, gnome3


libQuotient and libqmatrixclient are not used.

Yeah, sorry, left in draft so people wouldn't review too closely. I just copied quaternion so there's lots of left over cruft. I'lll clean it up once it actually does something (anything) on launch.

cole-h · 2020-04-04T16:35:40Z

@GrahamcOfBorg eval

(bot's been having a bad time recently)

ajs124 · 2020-04-13T09:15:31Z

If you just want to try out this app and don't feel like finishing the package, they provide an AppImage, which you can run/package through appimageTools.wrapType2.

colemickens · 2020-05-19T21:53:01Z

Well, I'm making some progress at least.

colemickens · 2020-06-21T00:52:53Z

This is working for me now, but it needs cleanup before it's ready for review.

pkgs/applications/networking/instant-messengers/mirage/default.nix

jonringer · 2020-07-03T23:52:09Z

pkgs/applications/networking/instant-messengers/mirage/default.nix

+    olm pyotherside
+  ];
+
+  propagatedBuildInputs = pypkgs;


this also causes the python interpreter to be exported, and it's not really needed since you're wrapping the executable anyway.

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-84150-1]$ nix-shell --pure -p "with import ./nixpkgs {}; mirage-im" [nix-shell:/home/jon/.cache/nixpkgs-review/pr-84150-1]$ python --version Python 3.8.3

If I remove this line, I get these errors and it doesn't load:

~ 19:21:36 | Got library name: "/nix/store/3z4vm3gsf9zvsj9im9xmx8pmdia8cjqq-pyotherside-1.5.9/lib/qt-5.12.7/qml/io/thp/pyotherside/libpyothersideplugin.so" ~ 19:21:36 | Using Wayland-EGL ~ 19:21:36 | Using the 'xdg-shell' shell integration ~ 19:21:36 | "PyOtherSide error: Traceback (most recent call last):\n\n File \"qrc:/src/backend/qml_bridge.py\", line 26, in <module>\n from .pyotherside_events import CoroutineDone, LoopException\n\n File \"qrc:/src/backend/pyotherside_events.py\", line 8, in <module>\n from .utils import serialize_value_for_qml\n\n File \"qrc:/src/backend/utils.py\", line 23, in <module>\n import aiofiles\n\nModuleNotFoundError: No module named 'aiofiles'\n" ! 19:21:36 | Unhandled PyOtherSide error: Cannot import module: backend.qml_bridge (Traceback (most recent call last): File "qrc:/src/backend/qml_bridge.py", line 26, in <module> from .pyotherside_events import CoroutineDone, LoopException File "qrc:/src/backend/pyotherside_events.py", line 8, in <module> from .utils import serialize_value_for_qml File "qrc:/src/backend/utils.py", line 23, in <module> import aiofiles ModuleNotFoundError: No module named 'aiofiles' ) ~ 19:21:36 | "PyOtherSide error: Traceback (most recent call last):\n\n File \"<string>\", line 1, in <module>\n\nNameError: name 'BRIDGE' is not defined\n" ! 19:21:36 | Unhandled PyOtherSide error: Function not found: 'BRIDGE.call_backend_coro' (Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'BRIDGE' is not defined )

going to push these commits up just so you can verify.

Yea, I was looking into a way around this, the buildPythonPath searches what being propagated to collect the entire python dependency tree. However, this also exports the python interpreter to the user's environment :(

pkgs/applications/networking/instant-messengers/mirage/default.nix

jonringer · 2020-07-07T01:07:01Z

do you mind squashing/removing some of the fixup commits, particularly:

mirage: feedback
mirage: also remove propagatedBuildInputs
Revert "mirage: also remove propagatedBuildInputs"

jonringer

I can't think of a way to improve this. I would like to prevent the python interpreter from getting propagated.
cc @FRidh

otherwise, the app seems to work, and the gui launches fine

https://github.com/NixOS/nixpkgs/pull/84150
1 package built:
mirage-im

symphorien · 2020-08-10T12:01:03Z

One way to prevent propagation of python is:

diff --git a/pkgs/applications/networking/instant-messengers/mirage/default.nix b/pkgs/applications/networking/instant-messengers/mirage/default.nix
index 1101d6f9b06..8e99ca64123 100644
--- a/pkgs/applications/networking/instant-messengers/mirage/default.nix
+++ b/pkgs/applications/networking/instant-messengers/mirage/default.nix
@@ -44,7 +44,10 @@ mkDerivation rec {
     wrapProgram $out/bin/mirage \
       --prefix PYTHONPATH : "$PYTHONPATH" \
       "''${qtWrapperArgs[@]}"
-    '';
+  '';
+  postFixup = ''
+    rm $out/nix-support -r
+  '';
 
   meta = with lib; {
     description = "A fancy, customizable, keyboard-operable Qt/QML+Python Matrix chat client for encrypted and decentralized communication.";

doronbehar reviewed Apr 3, 2020

View reviewed changes

doronbehar mentioned this pull request Apr 3, 2020

Some PRs trigger: code: 2, kind: NotFound, message: "No such file or directory" NixOS/ofborg#446

Closed

colemickens force-pushed the nixpkgs-mirage branch 2 times, most recently from e3db78e to e52598b Compare May 19, 2020 21:52

colemickens force-pushed the nixpkgs-mirage branch from e52598b to ffbfe1c Compare May 19, 2020 21:54

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 19, 2020

colemickens force-pushed the nixpkgs-mirage branch from ffbfe1c to 1eaac97 Compare June 21, 2020 00:52

ofborg bot added the 6.topic: python label Jun 21, 2020

colemickens force-pushed the nixpkgs-mirage branch from 1eaac97 to ef5e21d Compare June 21, 2020 00:58

ofborg bot requested review from tilpner, symphorien and emilazy June 21, 2020 01:00

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jun 21, 2020

colemickens force-pushed the nixpkgs-mirage branch 2 times, most recently from 70ebc31 to 1c02541 Compare June 21, 2020 01:49

colemickens changed the title ~~mirage: init~~ mirage: init at 0.5.1 Jun 21, 2020

colemickens force-pushed the nixpkgs-mirage branch from eefca66 to 7b03f0f Compare July 3, 2020 23:39

jonringer reviewed Jul 4, 2020

View reviewed changes

colemickens force-pushed the nixpkgs-mirage branch from 19215e4 to 30c3330 Compare July 7, 2020 00:44

ofborg bot added 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jul 7, 2020

colemickens force-pushed the nixpkgs-mirage branch from 30c3330 to abf54cd Compare July 7, 2020 00:59

colemickens force-pushed the nixpkgs-mirage branch from abf54cd to d83ba02 Compare July 7, 2020 01:09

colemickens added 2 commits July 6, 2020 18:10

mirage: init at 0.5.1

cb37038

mirage: 0.5.1 -> 0.5.2

fa027d9

colemickens force-pushed the nixpkgs-mirage branch 2 times, most recently from 8d2aca1 to fa027d9 Compare July 7, 2020 01:12

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 7, 2020

jonringer approved these changes Jul 7, 2020

View reviewed changes

Atemu mentioned this pull request Jul 10, 2020

matrix-mirage: init at 0.5.1 #92851

Closed

10 tasks

mirukana mentioned this pull request Jul 19, 2020

Naming conflict with Mirage image viewer (Linux Packaging) mirukana/mirage#103

Closed

jonringer merged commit 00c0d79 into NixOS:master Aug 10, 2020

colemickens deleted the nixpkgs-mirage branch December 30, 2022 01:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mirage: init at 0.5.1 #84150

mirage: init at 0.5.1 #84150

colemickens commented Apr 3, 2020 •

edited

doronbehar left a comment

doronbehar Apr 3, 2020

colemickens Apr 4, 2020

cole-h commented Apr 4, 2020

ajs124 commented Apr 13, 2020

colemickens commented May 19, 2020

colemickens commented Jun 21, 2020

jonringer Jul 3, 2020

colemickens Jul 4, 2020

colemickens Jul 4, 2020

jonringer Jul 4, 2020

jonringer commented Jul 7, 2020

jonringer left a comment

symphorien commented Aug 10, 2020

		@@ -0,0 +1,30 @@
		{ mkDerivation, stdenv, lib, fetchFromGitHub, cmake, qtbase, qtquickcontrols2
		, qtkeychain, qtmultimedia, qttools, libqmatrixclient_0_5, libQuotient, gnome3

mirage: init at 0.5.1 #84150

mirage: init at 0.5.1 #84150

Conversation

colemickens commented Apr 3, 2020 • edited

Motivation for this change

Things done

doronbehar left a comment

Choose a reason for hiding this comment

doronbehar Apr 3, 2020

Choose a reason for hiding this comment

colemickens Apr 4, 2020

Choose a reason for hiding this comment

cole-h commented Apr 4, 2020

ajs124 commented Apr 13, 2020

colemickens commented May 19, 2020

colemickens commented Jun 21, 2020

jonringer Jul 3, 2020

Choose a reason for hiding this comment

colemickens Jul 4, 2020

Choose a reason for hiding this comment

colemickens Jul 4, 2020

Choose a reason for hiding this comment

jonringer Jul 4, 2020

Choose a reason for hiding this comment

jonringer commented Jul 7, 2020

jonringer left a comment

Choose a reason for hiding this comment

symphorien commented Aug 10, 2020

colemickens commented Apr 3, 2020 •

edited