Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{h,a}spell: split outputs -> closure size reduction #76166

Closed
wants to merge 3 commits into from
Closed

{h,a}spell: split outputs -> closure size reduction #76166

wants to merge 3 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 22, 2019 •
edited

Motivation for this change

tested by fixing typos in our README, also build all packages that have aspell/hspell in buildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alyssais
Copy link
Member

Failed to evaluate aspell-dict-he-1.1: «broken-outputs»: has invalid meta.outputsToInstall'

@Mic92
Copy link
Member Author

Mic92 commented Apr 2, 2020

Maybe someone else wants to pick up this one.

@Mic92 Mic92 closed this Apr 2, 2020
@Mic92 Mic92 deleted the spell branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @alyssais