Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.12.0 -> 1.12.1 #84118

Merged
merged 1 commit into from Apr 2, 2020
Merged

matrix-synapse: 1.12.0 -> 1.12.1 #84118

merged 1 commit into from Apr 2, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 2, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 2, 2020
@Ma27 Ma27 requested review from mguentner, fadenb and pacien April 2, 2020 15:51
@Ma27
Copy link
Member Author

Ma27 commented Apr 2, 2020

@GrahamcOfBorg test matrix-synapse

@ofborg ofborg bot requested review from Ekleog and Ralith April 2, 2020 16:28
@Ma27
Copy link
Member Author

Ma27 commented Apr 2, 2020

Will bump to https://github.com/matrix-org/synapse/releases/tag/v1.12.2 later

@Ekleog Ekleog merged commit 947d81c into NixOS:master Apr 2, 2020
@Ekleog
Copy link
Member

Ekleog commented Apr 2, 2020

Merged and backported as 50bfd35

@Ma27 Ma27 deleted the bump-matrix-synapse branch April 2, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguentner mguentner Awaiting requested review from mguentner

@fadenb fadenb Awaiting requested review from fadenb

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @Ekleog