Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: quoted urls for RFC45, only the rebuilds #84130

Merged
merged 1 commit into from Apr 5, 2020

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

This is part 2 of the RFC45 cleanup. There is something peculiar about these particular packages that makes ofborg want to rebuild them after only adding some quotes. So they were separated from the main PR.

@OmnipotentEntity
Copy link
Contributor Author

I also rolled a small fix for the buggy edge case that I mentioned @infinisi found with his script.

The package seems to be marked as broken however, so I dunno.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 2, 2020

Hmm, ihaskell does not look like fixing an URL. documentation-highlighter is a rebuild because it copies its dir including default.nix. Not sure about the other rebuilds

@OmnipotentEntity
Copy link
Contributor Author

OmnipotentEntity commented Apr 2, 2020

@7c6f434c ihaskell's derivation's original behavior is buggy, and that behavior was exposed by an automatic tool written by @infinisil to take care of this problem. The URL detected is PATH:+ and this is because the \${} does not prevent nix from attempting to evaluate PATH:+':' as a nix expression. Of course, this is unintended. The \ was intended to prevent this from being evaluated. But \ doesn't work inside of '' quoted strings. So this change is to fix that bug.

@bhipple bhipple changed the title RFC45 Clean up Part 2, only the rebuilds treewide: quoted urls for RFC45 part 2, only the rebuilds Apr 4, 2020
@bhipple bhipple changed the title treewide: quoted urls for RFC45 part 2, only the rebuilds treewide: quoted urls for RFC45, only the rebuilds Apr 4, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 4, 2020

Can you update the git commit subject to match the updated PR description? There are some guidelines for commit msg formatting in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md, but our convention for PRs touching a bunch of packages is to start it with treewide:

https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+in%3Atitle+treewide+

@bhipple
Copy link
Contributor

bhipple commented Apr 4, 2020

Result of nixpkgs-review pr 84130 1

1 package marked as broken and skipped:
- ihaskell
1 package blacklisted:
- tests.nixos-functions.nixos-test
5 packages built:
- documentation-highlighter
- iosevka
- ipfs-migrator
- lumo
- mendeley

@OmnipotentEntity
Copy link
Contributor Author

I would be happy to. I am sorry, I was unaware of the treewide name.

@OmnipotentEntity OmnipotentEntity force-pushed the rfc45-part2 branch 2 times, most recently from fcd7f04 to 1db3288 Compare April 4, 2020 21:15
@OmnipotentEntity
Copy link
Contributor Author

Fixed the trailing whitespace

@bhipple bhipple merged commit 0454fae into NixOS:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants