Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] haskell shellFor: Fix hoogle #84181

Merged
merged 1 commit into from Apr 3, 2020
Merged

[backport] haskell shellFor: Fix hoogle #84181

merged 1 commit into from Apr 3, 2020

Conversation

schmittlauch
Copy link
Member

(cherry picked from commit 1c07ee7)

Motivation for this change

backport of #80845 to fix #83783 in stable release-20.03 as well.

fixes #83783

Things done
  • rebuilt my nix-shell environment based on this PR
  • tested my code in the new environment
  • observed that during build of the environment, a hoogle DB gets created
  • successfully tried the hoogle command
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314 @schmittlauch
haskell shellFor: Fix hoogle
c565d7c 
(cherry picked from commit 1c07ee7)
@schmittlauch
Copy link
Member Author

ping @cdepillabout

@cdepillabout
Copy link
Member

Looks good, thanks!

@cdepillabout cdepillabout merged commit c778e13 into NixOS:release-20.03 Apr 3, 2020
@cdepillabout cdepillabout mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @cdepillabout @Ericson2314