Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boost #84182

Merged
merged 2 commits into from Apr 3, 2020
Merged

Update boost #84182

merged 2 commits into from Apr 3, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Required for updating pulseeffects, which is what I'm working on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Of course, the second patch is to be discussed whether it should land on master or whether it should be moved to staging.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer mentioned this pull request Apr 3, 2020
10 tasks
@Ma27 Ma27 merged commit 4458697 into NixOS:master Apr 3, 2020
@matthiasbeyer matthiasbeyer deleted the update-boost branch April 3, 2020 14:42
@bhipple bhipple mentioned this pull request May 4, 2020
10 tasks
bhipple added a commit to bhipple/nixpkgs that referenced this pull request May 4, 2020
This was broken in NixOS#84182; pinning back to 1.71 fixes the build.
bhipple added a commit that referenced this pull request Jun 14, 2020
This was broken in #84182; pinning back to 1.71 fixes the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants