Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a7540294cfae
Choose a base ref
...
head repository: NixOS/nix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 47c568ee3246
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 2, 2020

  1. libexpr: remove unused attrError 

    The attrError variable is no longer used but still allocated on every
call to the findAlongAttrPath function.
    @andir
    andir committed Apr 2, 2020
    Copy the full SHA
    4fc4eb6 View commit details

Commits on Apr 3, 2020

  1. Merge pull request #3470 from andir/remove-unusued-attrError 

    libexpr: remove unused attrError
    @edolstra
    edolstra authored Apr 3, 2020
    Copy the full SHA
    47c568e View commit details
Showing with 0 additions and 3 deletions.
  1. +0 −3 src/libexpr/attr-path.cc
3 changes: 0 additions & 3 deletions src/libexpr/attr-path.cc
View file
Original file line number Diff line number Diff line change
@@ -37,9 +37,6 @@ std::pair<Value *, Pos> findAlongAttrPath(EvalState & state, const string & attr
{
Strings tokens = parseAttrPath(attrPath);

Error attrError =
Error(format("attribute selection path '%1%' does not match expression") % attrPath);

Value * v = &vIn;
Pos pos = noPos;