Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.azure-storage: 0.20.3 -> 0.36.0 #84126

Merged
merged 1 commit into from Apr 7, 2020
Merged

python3Packages.azure-storage: 0.20.3 -> 0.36.0 #84126

merged 1 commit into from Apr 7, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 2, 2020 •
edited

Motivation for this change

this package might be able to be dropped, it hasn't seen an update in 3 years, and has been split into the azure-mgmt-storage* packages.

However, it was bugging me that it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner April 2, 2020 18:08
@ofborg ofborg bot requested a review from olcai April 2, 2020 18:16
@jonringer jonringer merged commit 729000e into NixOS:master Apr 7, 2020
@jonringer jonringer deleted the bump-azure-storage branch April 7, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@olcai olcai Awaiting requested review from olcai

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer