Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wg-quick after wireguard got upstreamed #84173

Merged
merged 1 commit into from Apr 3, 2020
Merged

Fix wg-quick after wireguard got upstreamed #84173

merged 1 commit into from Apr 3, 2020

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Apr 3, 2020 •
edited

Motivation for this change

Do the same as in #80758 for wg-quick.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 3, 2020

CC @rnhmjoj

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 3, 2020

Looks good. It would be good to have a wg-quick NixOS test but that's another issue.
Thank you.

rnhmjoj
rnhmjoj requested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just reword the commit message according to the CONTRIBUTING.md?

@bkchr
Copy link
Contributor Author

bkchr commented Apr 3, 2020

@rnhmjoj done

@rnhmjoj rnhmjoj merged commit b483a67 into NixOS:master Apr 3, 2020
@bkchr bkchr deleted the bkchr-fix-wg-quick branch April 3, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkchr @rnhmjoj