Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.5.115 -> 1.5.123 #84151

Merged
merged 1 commit into from Apr 5, 2020
Merged

brave: 1.5.115 -> 1.5.123 #84151

merged 1 commit into from Apr 5, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Apr 3, 2020 •
edited

Motivation for this change

Keep Brave Browser up-to-date

Things done

Update version and checksum. Tested the build as well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and uskudnik April 3, 2020 01:34
@rht
Copy link
Member

rht commented Apr 3, 2020

LGTM

@rht
Copy link
Member

rht commented Apr 4, 2020

The PR title should be renamed to 1.5.123.

@JeffLabonte JeffLabonte changed the title brave: 1.5.115 -> 1.5.122 brave: 1.5.115 -> 1.5.123 Apr 4, 2020
@JeffLabonte
Copy link
Contributor Author

The PR title should be renamed to 1.5.123.

Yeah, I forgot to change this one. I changed it now.. thank you :)

@FRidh
Copy link
Member

FRidh commented Apr 5, 2020

@GrahamcOfBorg build brave

@FRidh FRidh merged commit e1c851a into NixOS:master Apr 5, 2020
This was referenced Apr 7, 2020
Merged
Merged
@JeffLabonte JeffLabonte deleted the brave_1.5.115_to_1.5.122 branch February 2, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffLabonte @rht @FRidh