Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clight: include location assertion #84154

Merged
merged 1 commit into from Nov 12, 2021
Merged

clight: include location assertion #84154

merged 1 commit into from Nov 12, 2021

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 3, 2020

Motivation for this change

#83923

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu force-pushed the clight/location-assertion branch from 9ee58c8 to 13f9a35 Compare April 7, 2020 18:16
@eadwu
Copy link
Member Author

eadwu commented May 15, 2020

A ping one month later, @worldofpeace

@stale
Copy link

stale bot commented Nov 11, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 11, 2020
@SuperSandro2000
Copy link
Member

@eadwu @worldofpeace friendly ping

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 24, 2020
@cyplo
Copy link
Contributor

cyplo commented Feb 21, 2021

Hi, running nix-shell -p nixpkgs-review --run "nixpkgs-review pr 84154" works for me, do we need anything else to merge this one ?

@j0hax
Copy link
Member

j0hax commented Jun 15, 2021

I'm also interested in getting clight to work 😃

@TheSirC
Copy link

TheSirC commented Aug 31, 2021

Friendly ping again ! 🔔

@SuperSandro2000 SuperSandro2000 merged commit fee23ab into NixOS:master Nov 12, 2021
@ralismark ralismark mentioned this pull request Mar 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @SuperSandro2000 @cyplo @j0hax @TheSirC