Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darcs: Fix build (Use old GHC) #84155

Closed
wants to merge 28 commits into from
Closed

darcs: Fix build (Use old GHC) #84155

wants to merge 28 commits into from

Conversation

chkno
Copy link
Member

@chkno chkno commented Apr 3, 2020

Motivation for this change

Fix darcs by switching it to an older version of GHC.

This is the seventh or eighth time we've done this. Past times:

  1. da57804 - d2d8d83?
  2. b1ec2a1 - 37f707f
  3. f0fcaa0 - 73bee7d
  4. 21a83ed - darcs updated to 2.8.5 #3792 (@peti, @MP2E)
  5. 3b8ae5c - f8d5b67 (@peti, @MP2E)
  6. 3a4ff5f - 3594e34 (@peti, @peti)
  7. ab3a12e - darcs: unpin ghc (use 8.4.x) version #46707 (@peti, @srhb)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 24 commits March 28, 2020 02:30
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@cc26152.
The tests have x86_64 results hardcoded, see
hspec/hspec#431.
haskellPackages.hspec-core: Disable tests on i686.
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@c0a41f1.
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@b4df64c.
futhark: build and install manpages
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@ff50a99.
It needs an older version of ghc-tcplugins-extra.
The package is unmaintained and now broken for other reasons.
haskellPackages.pandoc-crossref: fix build and more
also fixes mattermost-api, mattermost-api-qc,
and adds them to stewardship by kiwi
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@6fb35f2.
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@56abf5b.
same for `hookup` which is part of/required by irc-core/glirc
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@90a8fe2.
This update was generated by hackage2nix v2.15.1 from Hackage revision
commercialhaskell/all-cabal-hashes@a18f127.
This is fixed at upstream's head; this change can be reverted after
darcs cuts a new release (current release is 2.14.2).
@peti peti changed the base branch from master to haskell-updates April 3, 2020 18:43
@peti peti changed the base branch from haskell-updates to master April 3, 2020 19:15
@peti
Copy link
Member

peti commented Apr 3, 2020

Merged in 239d72c already.

@peti peti closed this Apr 3, 2020
@chkno
Copy link
Member Author

chkno commented Apr 3, 2020

Thanks peti! (Sorry, folks that got spurious review requests from the base-branch change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet